Add conditionnals to detect gpsd API version #188
Conversation
|
Why we cannot make just the definition conditional? In the second change we read the same attribute and compare it with the same constant. I am sure you did it for some reason, I just would like to know that reason. ;) |
|
No, I have not done this for a reason, and the suggestions are very welcome ! I always make a point of matching any code style policy or coding preferences when contributing, so no problem. My initial patch was worked out in a few minutes... It probably needs some refining. |
|
No, I have not done this for a reason, and the suggestions are very welcome ! My initial patch was worked out in a few minutes... It probably needs some refining. |
| @@ -279,8 +282,11 @@ IPState GPSD::updateGPS() | |||
| break; | |||
| } | |||
|
|
|||
|
|
|||
| #if GPSD_API_MAJOR_VERSION >= 10 | |||
| if (gpsFix->status == STATUS_NO_FIX) | |||
There was a problem hiding this comment.
This change is bogus as the pointer is not initialized anywhere. The status field has indeed moved so the check should be:
if (gpsData->fix.status == STATUS_NO_FIX)
Co-authored-by: Marc-Olivier Barre <marc-olivier.barre@intercloud.com>
Attempted quick fix for issue #187. This will certainly require some testing (don't have a laptop GPS yet, so can't really test this).