Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asi_ccd/refactoring - using std containers #265

Merged
merged 2 commits into from Dec 17, 2020

Conversation

pawel-soja
Copy link
Contributor

Hi!

I am getting to know the library and I made a few simplifications.

  • Using std::unordered_map
  • Using foreach instead of for
  • Replacing a function in a simulation
  • Changing the names of cameras in the simulation.
  • Using the std::swap function

Regards
Pawel

@knro
Copy link
Collaborator

knro commented Dec 17, 2020

Thank you, it's great to see modern C++ being utilized here. Where is the foreach part though?

@pawel-soja
Copy link
Contributor Author

Where is the foreach part though?

What do you mean?
I got rid of the cleanup function completely. The memory is freed by the containers.
And in some places I used for ( : )

@knro knro merged commit 28397ef into indilib:master Dec 17, 2020
@pawel-soja pawel-soja deleted the asi_ccd/refactoring branch December 17, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants