Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for broken temperature regulation in Indi-qhy #42

Merged
merged 5 commits into from
Dec 30, 2019

Conversation

dirkschwarze
Copy link
Contributor

Fix contains 3 changes to file qhy_ccd.cpp:

  1. Reduce temp_threshold.
  2. Continue to read temperature, even if IPS_OK, to detect drift...
  3. Restart regulation if drift causes to leave the threshold area.

@knro
Copy link
Collaborator

knro commented Dec 30, 2019

So QHY cameras work in Auto mode and manual mode.. this change caters to both? Manual you just set PWM at a specific value regardless of temperature. While auto you set the temperature and let the driver adjusts the PWM accordingly.

@dirkschwarze
Copy link
Contributor Author

dirkschwarze commented Dec 30, 2019 via email

@knro
Copy link
Collaborator

knro commented Dec 30, 2019

Tested today and at least I don't see regressions with temperature control on QHY163

@knro knro merged commit ba2815f into indilib:master Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants