Adopt ASI driver to simulator behavior and like QHY driver #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jasem,
based on our discussion on INDI forum, I cleaned up the VERBOSE_EXPOSURE time as constant and adjusted the sending of CCD_EXPOSURE = 0 only if the exposure is finished. The solution is used in the QHY driver as well, which also only reports CCD_EXPOSURE back if timeLeft is bigger than 0.0049 s. Both driver set the CCD_EPOSURE value to 0 explicit anyway if exposure is finished.
I cannot build myself, so please review an accept if ok or comment if wrong.
Michel