Updates to DDW driver #1344
Merged
Updates to DDW driver #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jpaana
commented
Feb 3, 2021
jpaana
commented
- restrict to serial connection as the controller only support that to avoid confusion
- if dome is currently moving when a new command to move arrives (from slaving or similar), latch the command and issue the goto after current one completes
- the state of DomeAbsPosNP was set to IPS_OK too early in a few places causing client to think move is over, corrected those so the state stays IPS_BUSY correctly until the move is actually finished
- restrict to serial connection as the controller only support that to avoid confusion - if dome is currently moving when a new command to move arrives (from slaving or similar), latch the command and issue the goto after current one completes - the state of DomeAbsPosNP was set to IPS_OK too early in a few places causing client to think move is over, corrected those so the state stays IPS_BUSY correctly until the move is actually finished
karlrees
pushed a commit
to karlrees/indi
that referenced
this pull request
Mar 24, 2021
- restrict to serial connection as the controller only support that to avoid confusion - if dome is currently moving when a new command to move arrives (from slaving or similar), latch the command and issue the goto after current one completes - the state of DomeAbsPosNP was set to IPS_OK too early in a few places causing client to think move is over, corrected those so the state stays IPS_BUSY correctly until the move is actually finished
karlrees
added a commit
to karlrees/indi
that referenced
this pull request
Mar 24, 2021
This reverts commit 6535e30.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.