Improving Dome slave to telescope regarding telescope pier side #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to improve the interpretation of the pier side of telescope in calculating the dome azimuth, 3 more options were added to OTASideSP switch. To East and West manual setting, options form as reported by Mount, implied by Hour Angle or Ignore options were added.
|
@jpaana Can you please give some feedback? I think Peter Kennet can perhaps help in the testing? |
|
@knro @jpaana had posted a comment about it in the bug report: |
|
Yes, in my testing it seems the pier side is consistently flipped in this change. |
|
Right how about the "few issues" raised here: #1364 (comment) ? Are these resolved as well? |
|
Corrections of errors reported by @jpaana in #1364 (comment) |
|
Thanks, tested this new version and everything seems to be in order now. Pier side works as expected and setting is also saved, thanks! |
karlrees
pushed a commit
to karlrees/indi
that referenced
this pull request
Mar 24, 2021
karlrees
added a commit
to karlrees/indi
that referenced
this pull request
Mar 24, 2021
…de (indilib#1373)" This reverts commit b5ee0a6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for a solution of this bug (#1364) I improved how Dome drivers deal with the side of the pier where the telescope is in GEM mounts.
Before this change, user can inform to Dome driver which side was the telescope, but if the mount has this information, then it takes from the mount. However, in some circuntances (when telescope was moving) it's not clear what side must be taken.
To make the dome driver behaviour more predictable and clear, now the user can choose from 5 diferent options:
East : Dome always positions as if telescope tube was at the east of the pier
West: Dome always positions as if telescope tube was at the west of the pier
Mount: Dome positions as if the telescope tube was at the side the mount reports. If the mount didn't report the side, the dome behave as with a fork mount.
Hour Angle: Dome positions as if the telescope tube was at the side deducted by the hour angle of the target coordinates. For positive hour angle (telescope point to west of the meridian) the tube was in the east side.
Ignore: Dome positios as with a fork mount.
A final note: When configured as Mount and the telescope slews from one side to the other side of the pier, the dome positions to the "wrong" side when the telescope begins moving, and then repositions to the correct side when the telescope end slewing. I have not found any solution for this behaviour, so I left for a future change if a solution is found.