The driver for the Planewave Delta-T was not working #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using plain char as a type for anything else than ASCII text is prone to problems as C and C++ standards don't specify whether it is signed or unsigned and that depends on the architecture. It's unsigned on ARM and signed on x86/x64. So strongly recommended to use (u)int8_t, (un)signed char or anything that specifies signedness explicitly. |
|
Good point, int8_t should probably be used. |
|
Thanks for that suggestion, I have not that much experience with C++, so I thought it was a good solution to my problem, I will try changing the type to int8_t. |
knro
pushed a commit
that referenced
this pull request
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver for the Planewave Delta-T was not working, it always displayed "Invalid Checksum", even tho the checksum was correct. Changing the type of the checksum from
uint8_ttocharfixed everything, and the driver is now working properly