Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial release of Alluna TCS2 Driver #1991

Merged
merged 4 commits into from Feb 7, 2024

Conversation

peter-englmaier
Copy link
Contributor

The Telescope-Control-System TCS of ALLUNA Optics, has been designed for the remote control of high-quality telescopes. Alluna Optics provides only ASCOM drivers and a Windows EXE program to control the TCS2 Device. The TCS2 can also be controlled by an optional handheld device.

The indi driver has been developed by me, Peter Englmaier, and I am not affiliated with Alluna Optics, but own a small Alluna Telescope and want to use it with Ekos and other indi software.

With TCS several telescope functions are controlled and monitored:

  • Air conditioning of the optical tube and the main mirror i.e., primary/secondary mirror heating and ventilation
  • Temperature of ambient (focuser), primary and secondary mirror
  • Focusing of the optics
  • Control of the optionally available CCD Rotator
  • Control of the optionally available robotic Dust Cover
  • Setting configuration parameters

As I do not have the rotator option, I have not (yet) implemented that part. Also some less useful functions are still missing.

But it is possible, to use the focuser with ekos, control the dust cover, and the climate settings.

Please let me know, if I need to refactor something. Some parts of the code are cut&paste from other drivers.

The Telescope-Control-System TCS of ALLUNA Optics, has been designed
for the remote control of high-quality telescopes. Alluna Optics 
provides only ASCOM drivers and a Windows EXE program to control the 
TCS2 Device. The TCS2 can also be controlled by an optional handheld 
device. 

The indi driver has been developed by me, Peter Englmaier, and I am 
not affiliated with Alluna Optics, but own a small Alluna Telescope 
and want to use it with Ekos and other indi software.

With TCS several telescope functions are controlled and monitored:
- Air conditioning of the optical tube and the main mirror
  i.e., primary/secondary mirror heating and ventilation
- Temperature of ambient (focuser), primary and secondary mirror
- Focusing of the optics
- Control of the optionally available CCD Rotator
- Control of the optionally available robotic Dust Cover
- Setting configuration parameters

As I do not have the rotator option, I have not (yet) implemented that 
part. Also some less useful functions are still missing. 

But it is possible, to use the focuser with ekos, control the dust 
cover, and the climate settings.
@peter-englmaier
Copy link
Contributor Author

I think I need to add documentation for https://indilib.org/individuals/devices/focusers.html
Please let me know, how I can do that.

@knro
Copy link
Contributor

knro commented Feb 4, 2024

Thank you Peter. Can you please use INDI::PropertyXXX (e.g. INDI::PropertyNumber) instead of the old ISwitch/INumber properties? For the documentation, you can attach a zip file with the documentation + images and we'll upload them to INDI website.

@peter-englmaier
Copy link
Contributor Author

Yes, I can do that. Is the indi the right place for the driver or should I move it to indi-3rdparty? I find focuser drivers in both places.

@knro
Copy link
Contributor

knro commented Feb 4, 2024

Without any external dependencies, it should stay in indi-core.

@peter-englmaier
Copy link
Contributor Author

Ok, I replaced the ISwitch/INumber properties. I think there is no way, to also replace the ones inherited from INDI::Focuser.

The code compiles fine, but I have to do some tests within my observatory now. So please do not merge, yet.
Simulation mode was also removed, because it is not implemented.
Anything else I should change?

@knro
Copy link
Contributor

knro commented Feb 5, 2024

This looks great now. Please let us know once you tested the code.

@peter-englmaier
Copy link
Contributor Author

I have tested the code and fixed a bug introduced by the refactoring. Now it seems to work fine. I hope I also fixed the warning about unused variable which made the mac build "break".

@knro
Copy link
Contributor

knro commented Feb 7, 2024

Can you add an entry as well to drivers.xml ?

@peter-englmaier
Copy link
Contributor Author

@knro Ok, I changed the drivers.xml. What is it used for? I had no problem finding and using the driver within kstars.

@knro knro merged commit 5e699ca into indilib:master Feb 7, 2024
11 checks passed
@peter-englmaier peter-englmaier deleted the pullrequest branch February 7, 2024 17:02
@peter-englmaier
Copy link
Contributor Author

Thanks for merging my pull request so quickly ;-)

Now, I should follow up on this:

For the documentation, you can attach a zip file with the documentation + images and we'll upload them to INDI website.

This will take some time to do, so please be patient.

@peter-englmaier
Copy link
Contributor Author

@knro please find here the documentation for the website:
alluna-indi-docu.zip

@knro
Copy link
Contributor

knro commented Feb 10, 2024

@naheedsa please add above to INDI & StellarMate moset tree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants