Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/disable EOS camera mirror lockup with custom function #620

Merged
merged 1 commit into from Jun 20, 2018
Merged

Enable/disable EOS camera mirror lockup with custom function #620

merged 1 commit into from Jun 20, 2018

Conversation

tstibor
Copy link
Contributor

@tstibor tstibor commented Jun 20, 2018

Employ PTP property called CustomFuncEx to enable/disable mirror
lockup for EOS cameras. Before this commit mirror lockup works only,
when mirror lockup is enabled by hand via the EOS camera menu.
Details of the EOS customfuncex are provided at
https://github.com/gphoto/libgphoto2/blob/master/camlibs/ptp2/canon-eos-customfunc.txt

The CustomFuncEx can be tested with gphoto2 as follows:

enable mirror lockup:
gphoto2 --set-config customfuncex=20,1,3,14,1,60f,1,1

disable mirror lockup:
gphoto2 --set-config customfuncex=20,1,3,14,1,60f,1,0

Employ PTP property called CustomFuncEx to enable/disable mirror
lockup for EOS cameras. Before this commit mirror lockup works only,
when mirror lockup is enabled by hand via the EOS camera menu.
Details of the EOS customfuncex are provided at
https://github.com/gphoto/libgphoto2/blob/master/camlibs/ptp2/canon-eos-customfunc.txt

The CustomFuncEx can be tested with gphoto2 as follows:

enable mirror lockup:
gphoto2 --set-config customfuncex=20,1,3,14,1,60f,1,1

disable mirror lockup:
gphoto2 --set-config customfuncex=20,1,3,14,1,60f,1,0
@knro
Copy link
Contributor

knro commented Jun 20, 2018

Great idea, looks good to me!

@knro knro merged commit 10ff249 into indilib:master Jun 20, 2018
@knro
Copy link
Contributor

knro commented Jul 18, 2018

Can you please take a look at this report? http://indilib.org/forum/general/3620-indi-gphoto-ccd-with-dslr-t7i.html#27564

From the logs, I see that setting the custom function happen at 83.13 seconds mark, and then all subsequent exposures fail. MirrorLock value was also at 0.

@tstibor
Copy link
Contributor Author

tstibor commented Jul 19, 2018

Yes indeed it looks like setting customfuncex: 20,1,3,14,1,60f,1,0 (disable mirror lockup)
causes the problem. A quick fix would be probably to #if 0 the two enable/disable settings:

#if 0
gphoto_set_widget_text(gphoto, gphoto->customfuncex_widget,                                                         
                               EOS_MIRROR_LOCKUP_ENABLE); 
gphoto_set_widget_text(gphoto, gphoto->customfuncex_widget,                                                     
                                   EOS_MIRROR_LOCKUP_DISABLE);
#endif 

Do you also have the problem with your DSLR @knro. I have a Canon 700D and it works without any problems. If this problem occurs only on some EOS cameras one could strcmp for the model and disable for them the mirror lockup feature.

@knro
Copy link
Contributor

knro commented Jul 19, 2018

@tstibor No issues here either with 600D. So far we have 2 different cameras that reported issues.

I'll add the #if0 for now until we arrive at a better solution.

knro added a commit that referenced this pull request Jul 19, 2018
INDI users reported PR #620 caused issues for their canon cameras at http://indilib.org/forum/general/3620-indi-gphoto-ccd-with-dslr-t7i.html

For now, disabling this until we figure out how to limit it to cameras that are known to support it for sure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants