Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nighscape 8300 Driver/Optec IFW supports TCP/IP #648

Merged
merged 50 commits into from
Jul 15, 2018

Conversation

dirkenstein
Copy link
Contributor

new pull request to replace yesterday's as this failed a number of compile options due to D2XX being mandatory.

New version will now build as long as at least libftdi1 and libusb1 are available.

Also removed serial support by default as it doesn't work (kernel ftdi_sio driver can't handle bulk data well).

@knro
Copy link
Contributor

knro commented Jul 14, 2018

@jochym What's going on with the CI?

@knro
Copy link
Contributor

knro commented Jul 15, 2018

Can you please rebase to fix the conflict above? Also, I think we need to provide documentation for this over at indilib.org (e.g. http://indilib.org/devices/ccds/apogee-ccd.html)

@knro
Copy link
Contributor

knro commented Jul 15, 2018

Great work! The documentation + screenshots would be greatly appreciated!!

@knro knro merged commit 5981ae4 into indilib:master Jul 15, 2018
@dirkenstein
Copy link
Contributor Author

Is there a standard format for the docs at indilib.org?
I guess you want ekos screenshots. Do you have the source for the apogee doc page so i can edit it appropriately.

I've added the standard text documents in the source dir and pushed them.

@knro
Copy link
Contributor

knro commented Jul 15, 2018

Do you have a user account on INDI Library website? I can give you permissions to create a new listing.

@dirkenstein
Copy link
Contributor Author

My forum account is dirkn.

@knro
Copy link
Contributor

knro commented Jul 15, 2018

Ok you have permission now. You can now edit this --> http://indilib.org/devices/ccds/celestron-nightscape-8300.html

@dirkenstein
Copy link
Contributor Author

Edits completed, hopefully sufficient for the purpose.

@knro
Copy link
Contributor

knro commented Jul 15, 2018

Wow that was fast! Thanks a lot! I just added an image. I'll try to prepare the 3rd party release today.

@knro
Copy link
Contributor

knro commented Jul 15, 2018

Ok I just pushed few improvements to the code. But I'm not sure what drop_root_privileges() is for? Is the driver required to start as root to set it as high priority (renice to -20) which would require root privileges?

@dirkenstein
Copy link
Contributor Author

Hi Jasem,

The drop_root_privileges is only needed if you run the driver setuid root. It's optional, and has no effect on the driver if run as a normal user.

I don't provide instructions for doing it because it's inherently a bad idea, but it may be needed in two scenarios:

a) setting up your driver to have access to the USB devices without root needs some udev scripts on Linux. I can provide these if required so the usb device for the nightscape is added to group 'usb'. You add your indi user to that group and it has access to the device.

b) Setting priority to -20 helps with the USB stability on my mac. It may not have as much affect for everyone. You can't renice to -20 without root privileges or some really complicated /etc/limits settings.

@knro
Copy link
Contributor

knro commented Jul 15, 2018

Excellent, do you have the VID:PID for the camera so I can add a udev rule at least for Linux users?

@dirkenstein
Copy link
Contributor Author

This rule works

SUBSYSTEMS=="usb", ATTRS{product}=="Nightscape CCD Camera", GROUP="usb"

@dirkenstein
Copy link
Contributor Author

VID and PID 👍
int vid = 0x19b4;
int pid = 0x0065;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants