Renewed update to work with spaces in categories #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems legit. Thanks! |
indirect
added a commit
that referenced
this pull request
Mar 21, 2013
Renewed update to work with spaces in categories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated
postfiles.rbto work with posts that have a space in the category. Unlike the previous contributor, I noticed that spaces (and I assume other special characters) got escaped by Jekyll before storing in thepost.id. So for example "this category" would get an id starting with "/this%20category/" instead of "/this category/".Did not check what caused this change in behaviour, assuming something changed in jekyll.
Tested it only on a small site of my own (not an experienced Ruby programmer yet), so please review carefully.