Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Support #10

Closed
jamztang opened this issue Apr 11, 2015 · 10 comments
Closed

Image Support #10

jamztang opened this issue Apr 11, 2015 · 10 comments

Comments

@jamztang
Copy link

I noticed that the images are not being implemented in the CMAttributedStringRenderer. Is there a plan for that?

I've been trying to work on an asynchronous version and getting some progress here.

@indragiek
Copy link
Owner

I didn't plan on it, but contributions are always welcome. Send a pull request if you implement it :)

@indragiek indragiek mentioned this issue Sep 8, 2015
@krodak
Copy link

krodak commented Jan 6, 2016

@jamztang - I've added fully working image support, you can check it out here:

https://github.com/X8/CocoaMarkdown/tree/feature/SupportImageTag

I'll try to find some time to refactor it and remove CocoaPods support from CocoaMarkdown itself as @indragiek don't want to have it (and I fully understand this).

@indragiek
Copy link
Owner

@krodak Very cool! After refactoring, please feel free to send a pull request. Looking forward to reviewing it!

@mjstallard
Copy link
Contributor

@krodak I agree with @indragiek - this would be great to see, hope you get chance to refactor!

@krodak
Copy link

krodak commented Jan 29, 2016

@mjstallard I still work on the feature, have few more bugs fixed, you can track it and fork it from my development branch.

I'll refactor it after #20 is accepted, to be sure that my approach is consistent with current CM implementation.

@mjstallard I'll let you know when it's finished.

@albertbori
Copy link

Any update on this? Images are crucial markdown feature for my project.

@indragiek
Copy link
Owner

@krodak #20 has been merged.

@cpowers
Copy link

cpowers commented Jun 8, 2016

@krodak Any plans on finishing this integration? It would be a very nice feature.

@iby
Copy link
Contributor

iby commented Sep 13, 2016

@krodak 👏 @krodak 👏 @krodak 👏

@indragiek
Copy link
Owner

Image support has been implemented in #49 thanks to @jlj!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants