-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image Support #10
Comments
I didn't plan on it, but contributions are always welcome. Send a pull request if you implement it :) |
@jamztang - I've added fully working image support, you can check it out here: https://github.com/X8/CocoaMarkdown/tree/feature/SupportImageTag I'll try to find some time to refactor it and remove CocoaPods support from CocoaMarkdown itself as @indragiek don't want to have it (and I fully understand this). |
@krodak Very cool! After refactoring, please feel free to send a pull request. Looking forward to reviewing it! |
@krodak I agree with @indragiek - this would be great to see, hope you get chance to refactor! |
@mjstallard I still work on the feature, have few more bugs fixed, you can track it and fork it from my development branch. I'll refactor it after #20 is accepted, to be sure that my approach is consistent with current CM implementation. @mjstallard I'll let you know when it's finished. |
Any update on this? Images are crucial markdown feature for my project. |
@krodak Any plans on finishing this integration? It would be a very nice feature. |
I noticed that the images are not being implemented in the CMAttributedStringRenderer. Is there a plan for that?
I've been trying to work on an asynchronous version and getting some progress here.
The text was updated successfully, but these errors were encountered: