Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add podspec #20

Merged
merged 4 commits into from
Feb 2, 2016
Merged

Add podspec #20

merged 4 commits into from
Feb 2, 2016

Conversation

pronebird
Copy link
Contributor

Very minimal support for iOS only. I bet OS X should work out of box if we add :osx to pod spec but I didn't test. The source code is left untouched. I removed CocoaMarkdown/Ono.h from CocoaMarkdown.h because it's not used anywhere but in CMAttributedStringRenderer.m where it is included as Ono.h which should work just fine for the time being.

This work is based on @krodak's effort in #19 but takes into account the fact that you would like to keep submodules.

Good to have in future:

  1. Separate private headers from public. Currently pod spec includes the entire folder but I bet there were some private headers that normally should not be exposed.
  2. Normalize import statements for dependencies, so they follow <LIBRARY/LIBRARY.h> pattern or something like that to avoid collisions.

After merge:

You would have to change the git URL in podspec, add tag to repo and put this tag in pod spec.

@krodak
Copy link

krodak commented Jan 29, 2016

@pronebird thanks a lot, unfortunately I didn't have time to integrate those changes in my current fork.

Once this is accepted I might merge it into my Markdown Images support and then post it as PR too :-)

👍 hope this will be integrated.

s.author = "Indragie Karunaratne"
s.platform = :ios, '8.0'

s.source = { :git => 'https://github.com/pronebird/CocoaMarkdown.git' }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong - for PR that integrates it into @indragiek repository you need to specify it as:
s.source = { :git => 'https://github.com/indragiek/CocoaMarkdown' }
I know you won't be able to test it until it's merge, but you can trust me on this, this need to point to original repository.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krodak I pointed that out in my PR message. There is also no tag, nor any kind of versioning for CocoaMarkdown. One way or another I think it would require the original author to correct and add couple of fields like :tag and :git.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tag is not necessary, if you change this one line it would work, that's the
most important
On Fri, 29 Jan 2016 at 16:57, Andrey Mikhaylov notifications@github.com
wrote:

In CocoaMarkdown.podspec
#20 (comment):

+Pod::Spec.new do |s|
+

  • s.name = 'CocoaMarkdown'
  • s.version = '1.0'
  • s.summary = 'Markdown parsing and rendering for iOS and OS X'
  • s.description = "CocoaMarkdown aims to solve two primary problems better than existing libraries:
    +More flexibility. CocoaMarkdown allows you to define custom parsing hooks or even traverse the Markdown AST using the low-level API.
    +Efficient NSAttributedString creation for easy rendering on iOS and OS X. Most existing libraries just generate HTML from the Markdown, which is not a convenient representation to work with in native apps."
  • s.author = "Indragie Karunaratne"
  • s.platform = :ios, '8.0'

@krodak https://github.com/krodak I pointed that out in my PR message.
There is also no tag, nor any kind of versioning for CocoaMarkdown. One way
or another I think it would require the original author to correct and add
couple of fields like :tag and :git.


Reply to this email directly or view it on GitHub
https://github.com/indragiek/CocoaMarkdown/pull/20/files#r51243079.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krodak I pushed another commit that fixes this along with explicit versions for cmark and Ono because CocoaMarkdown does not work with the latest cmark.

@krodak krodak mentioned this pull request Jan 29, 2016
Andrej Mihajlov added 2 commits January 30, 2016 11:29
CocoaMarkdown does not work with newer version of cmark.
@mjstallard
Copy link
Contributor

Any news on this? Although I'm not a CocoaPods kinda guy, @krodak is waiting on this before making a PR for his image support branch (https://github.com/X8/CocoaMarkdown/tree/feature/SupportImageTag) which would be super awesome to see 😄

@indragiek
Copy link
Owner

@pronebird @krodak @mjstallard Sorry for the delay, busy times! The podspec looks good to me. Merged. Thank you.

indragiek added a commit that referenced this pull request Feb 2, 2016
@indragiek indragiek merged commit 694c5e8 into indragiek:master Feb 2, 2016
@mjstallard
Copy link
Contributor

@indragiek thank you! 😄 🎉

@pronebird pronebird deleted the feature/podspec branch February 2, 2016 21:34
@pronebird
Copy link
Contributor Author

🍻 🍻 🍻

@pronebird
Copy link
Contributor Author

Hi,

I am not able to find CocoaMarkdown on CocoaPods.org. Is it possible to pod trunk push the library to the cloud please?

Thank you!

@jgrandelli jgrandelli mentioned this pull request Oct 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants