-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add podspec #20
Add podspec #20
Conversation
@pronebird thanks a lot, unfortunately I didn't have time to integrate those changes in my current fork. Once this is accepted I might merge it into my Markdown Images support and then post it as PR too :-) 👍 hope this will be integrated. |
s.author = "Indragie Karunaratne" | ||
s.platform = :ios, '8.0' | ||
|
||
s.source = { :git => 'https://github.com/pronebird/CocoaMarkdown.git' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong - for PR that integrates it into @indragiek repository you need to specify it as:
s.source = { :git => 'https://github.com/indragiek/CocoaMarkdown' }
I know you won't be able to test it until it's merge, but you can trust me on this, this need to point to original repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krodak I pointed that out in my PR message. There is also no tag, nor any kind of versioning for CocoaMarkdown. One way or another I think it would require the original author to correct and add couple of fields like :tag
and :git
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tag is not necessary, if you change this one line it would work, that's the
most important
On Fri, 29 Jan 2016 at 16:57, Andrey Mikhaylov notifications@github.com
wrote:
In CocoaMarkdown.podspec
#20 (comment):+Pod::Spec.new do |s|
+
- s.name = 'CocoaMarkdown'
- s.version = '1.0'
- s.summary = 'Markdown parsing and rendering for iOS and OS X'
- s.description = "CocoaMarkdown aims to solve two primary problems better than existing libraries:
+More flexibility. CocoaMarkdown allows you to define custom parsing hooks or even traverse the Markdown AST using the low-level API.
+Efficient NSAttributedString creation for easy rendering on iOS and OS X. Most existing libraries just generate HTML from the Markdown, which is not a convenient representation to work with in native apps."
- s.homepage = 'https://github.com/indragiek/CocoaMarkdown'
- s.license = 'MIT'
- s.author = "Indragie Karunaratne"
- s.platform = :ios, '8.0'
- s.source = { :git => 'https://github.com/pronebird/CocoaMarkdown.git' }
@krodak https://github.com/krodak I pointed that out in my PR message.
There is also no tag, nor any kind of versioning for CocoaMarkdown. One way
or another I think it would require the original author to correct and add
couple of fields like :tag and :git.—
Reply to this email directly or view it on GitHub
https://github.com/indragiek/CocoaMarkdown/pull/20/files#r51243079.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krodak I pushed another commit that fixes this along with explicit versions for cmark and Ono because CocoaMarkdown does not work with the latest cmark.
CocoaMarkdown does not work with newer version of cmark.
Any news on this? Although I'm not a CocoaPods kinda guy, @krodak is waiting on this before making a PR for his image support branch (https://github.com/X8/CocoaMarkdown/tree/feature/SupportImageTag) which would be super awesome to see 😄 |
@pronebird @krodak @mjstallard Sorry for the delay, busy times! The podspec looks good to me. Merged. Thank you. |
@indragiek thank you! 😄 🎉 |
🍻 🍻 🍻 |
Hi, I am not able to find CocoaMarkdown on CocoaPods.org. Is it possible to Thank you! |
Very minimal support for iOS only. I bet OS X should work out of box if we add
:osx
to pod spec but I didn't test. The source code is left untouched. I removedCocoaMarkdown/Ono.h
fromCocoaMarkdown.h
because it's not used anywhere but inCMAttributedStringRenderer.m
where it is included asOno.h
which should work just fine for the time being.This work is based on @krodak's effort in #19 but takes into account the fact that you would like to keep submodules.
Good to have in future:
<LIBRARY/LIBRARY.h>
pattern or something like that to avoid collisions.After merge:
You would have to change the git URL in podspec, add tag to repo and put this tag in pod spec.