Support for images and relative links in attributed string renderer. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Minor improvements. - Markdown images are now rendered in attributed strings (as text attachments) on iOS and macOS. - Image paragraph attributes can be specified by CMTextAttribute property `imageParagraphAttributes` (e.g. paragraph spacing, centering…). - Paragraph attributes can be specified by CMTextAttribute property `paragraphAttributes` (was previously hardcoded). - Added support for relative URIs in markdown link and images, i.e. for destination URIs that do not specify a URL scheme or host. The base URL for relative links or images can be defined via a new CMDocuments property `linksBaseURL` and is set by default as the document file's directory, so as to enable rendering of images in the document file's directory by simply specifying their filename like: `` - Upgraded cmark version to version0.29. - Updated example apps to Swift 4.2. - Added a markdown file selection button in the masOS example, with a `linksBaseURL` textfield on the file selection panel. This allows to quickly check the rendering of markdown files in various contexts. - Updated the default header attributes in CMTextAttribute to include paragraph-spacing for better default attributed string rendering. - Fixed CocoaMarkdownTests for consistency with test file `test.md`.
|
Wow, this is great! Thanks for working on this — I'll try to review as soon as possible. |
|
Any update on whether this is going to be merged in or not? We are looking at replacing our current Markdown library, and image functionality is crucial. Thanks! |
|
Sorry about the delay in getting to this, this looks great, merging! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I don't know if you are still maintaining this project, but if you are, you might be interested by this PR adding images and relative links to attributed string rendering on both iOS and macOS. Additionally I made a overall refresh to the project: cmark v0.29, Swift 4.2 example apps, paragraph attributes…
(see the commit message for all details).