Added SPM support, remove GLKit dependence #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved to using SIMD vector operations instead
Unfortunately simd support is only available from iOS 11 and macOS 10.13
|
@dagronf Thanks so much and sorry for the really late PR review, I just saw this! Appreciate it. |
indragiek
approved these changes
May 1, 2021
|
No problems at all mate. Glad I could help out! Thank you for all your work on this great library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch includes the following two changes
** Add support for Swift Package Manager**
I've added a Package.swift file at the root level that allows for both library and framework targets for DominantColor.
** Remove dependence on GLKit **
I've removed the dependence on GLKit by moving to SIMD structures as used by Metal. The change was mostly a simple name change (eg.
GLKVector3->simd_float3) and some simple replacements for a couple of the GLKit functions.As a result I've had to 'up' the versions from macOS 10.11 -> 10.13 and iOS 9 -> 11.