Content view frame checks for hideTitleBarInFullScreen in Fullscreen mode #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 1, 2014 11:11
…tent view correctly.
|
When it moves in fullscreen it doesnt check for the hideTitleBarInFullScreen which is causing the content view to overlap with the titlebar. |
| if (self.hideTitleBarInFullScreen) { | ||
| contentRect.size.height = NSHeight(windowFrame); | ||
| } | ||
| else { |
There was a problem hiding this comment.
Style: else on same line as the closing brace above it.
|
Looks good, just one little nitpick :) |
indragiek
added a commit
that referenced
this pull request
Jul 4, 2014
Content view frame checks for hideTitleBarInFullScreen in Fullscreen mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.