Fix noise drawing bounds and make title bar colors configurable. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 12, 2012 23:16
|
Thanks for this! Those properties are convenient. I had to make a few fixes to how the CGColors were being created because it didn't work for anything other than grayscale colors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does two things. There was a bug in the noise-drawing code in which the noise pattern wouldn't get drawn at the bottom-most pixel in the title bar if the baseline separator was disabled. This was causing some awkward transitions between the title bar and the window content for me.
The other thing is making the title bar colors configurable. It allows you to customize the appearance of the title bar without needing to redraw the whole thing if all you want to do is adjust the colors. This fixes issue #78 that I had previously opened.
I also replaced all tabs with spaces for consistency.