Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Swift Package Manager manifest file. #12

Merged
merged 2 commits into from
Jun 29, 2020

Conversation

McProb
Copy link
Contributor

@McProb McProb commented Jun 26, 2020

No description provided.

@tjh12c
Copy link

tjh12c commented Jun 26, 2020

@indragiek talked to you on Twitter, my coworker Rob ended up adding the SPM compatibility rather than myself. Let us know if anything looks off!

Copy link
Owner

@indragiek indragiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nits to make this more concise, thanks to both of you for contributing this!

Package.swift Outdated Show resolved Hide resolved
Package.swift Outdated Show resolved Hide resolved
Package.swift Outdated Show resolved Hide resolved
@McProb
Copy link
Contributor Author

McProb commented Jun 29, 2020

Happy to make the file more concise. I think it will be important to note that using package manager with this framework requires Xcode 12 or higher in order to include the xcassets. I think this is good to go. Thanks again!

@indragiek
Copy link
Owner

Thank you @McProb!

@indragiek indragiek merged commit 041d3f8 into indragiek:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants