Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failing rev-dep checks for insight #76

Closed
strengejacke opened this issue Feb 15, 2021 · 1 comment
Closed

failing rev-dep checks for insight #76

strengejacke opened this issue Feb 15, 2021 · 1 comment

Comments

@strengejacke
Copy link

insight was just submitted, and this is the result of the rev-dep-checks:

  Running the tests in ‘tests/testthat.R’ failed.
  Complete output:
    > library(testthat)
    > library(statsExpressions)
    > 
    > test_check("statsExpressions")
    Starting 2 test processes
    ══ Skipped tests ═══════════════════════════════════════════════════════════════
    ● On CRAN (19)
    
    ══ Failed tests ════════════════════════════════════════════════════════════════
    ── Failure (test-t-dataframes.R:23:5):  dataframes for parametric t-tests ──────
    `df_1` (`actual`) not equal to structure(...) (`expected`).
    
         names(actual) | names(expected)     
     [4] "p.value"     | "p.value"       [4] 
     [5] "method"      | "method"        [5] 
     [6] "estimate"    | "estimate"      [6] 
     [7] "conf.level"  - "ci.width"      [7] 
     [8] "conf.low"    | "conf.low"      [8] 
     [9] "conf.high"   | "conf.high"     [9] 
    [10] "effectsize"  | "effectsize"    [10]
    
    `actual$conf.level` is a double vector (0.89, 0.99, 0.9, 0.5)
    `expected$conf.level` is absent
    
    `actual$ci.width` is absent
    `expected$ci.width` is a double vector (0.89, 0.99, 0.9, 0.5)
    ── Failure (test-t-dataframes.R:98:5):  dataframes for parametric t-tests ──────
    `df_2_between` (`actual`) not equal to structure(...) (`expected`).
    
         names(actual) | names(expected)     
     [7] "p.value"     | "p.value"       [7] 
     [8] "method"      | "method"        [8] 
     [9] "estimate"    | "estimate"      [9] 
    [10] "conf.level"  - "ci.width"      [10]
    [11] "conf.low"    | "conf.low"      [11]
    [12] "conf.high"   | "conf.high"     [12]
    [13] "effectsize"  | "effectsize"    [13]
    
    `actual$conf.level` is a double vector (0.89, 0.99, 0.9, 0.5)
    `expected$conf.level` is absent
    
    `actual$ci.width` is absent
    `expected$ci.width` is a double vector (0.89, 0.99, 0.9, 0.5)
    ── Failure (test-t-dataframes.R:191:5):  dataframes for parametric t-tests ─────
    `df_2_within` (`actual`) not equal to structure(...) (`expected`).
    
         names(actual) | names(expected)     
     [5] "p.value"     | "p.value"       [5] 
     [6] "method"      | "method"        [6] 
     [7] "estimate"    | "estimate"      [7] 
     [8] "conf.level"  - "ci.width"      [8] 
     [9] "conf.low"    | "conf.low"      [9] 
    [10] "conf.high"   | "conf.high"     [10]
    [11] "effectsize"  | "effectsize"    [11]
    
    `actual$conf.level` is a double vector (0.89, 0.99, 0.9, 0.5)
    `expected$conf.level` is absent
    
    `actual$ci.width` is absent
    `expected$ci.width` is a double vector (0.89, 0.99, 0.9, 0.5)
    
    [ FAIL 3 | WARN 0 | SKIP 19 | PASS 69 ]
    Error: Test failures
    Execution halted

I think you have already adressed this? But just wanted to be sure so your update is ready once insight is on CRAN. :-)

@IndrajeetPatil
Copy link
Owner

These tests are already fixed in GitHub version. So no problem on this end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants