Make instantiation of Grounder more flexible #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the user to either specify terms_file as: - None -> look up the path and download the data from Amazon if necessary (old functionality) - str -> look up the grounding terms file at the given path - dict -> use a pre-made dictionary of normalized names to terms
Becuase of the functionality added in the last commit, the grounding terms path is looked up automatically (using the same get_grounding_terms() function) if none is given.
bgyori
force-pushed
the
improve-api-extensibility
branch
from
51b7851
to
3ee07f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the user to either specify the
terms_fileargument toGrounder.__init__()as either a:None-> look up the default path usinggilda.resources.get_grounding_terms()as well as ensure the data has been downloaded from Amazonstr-> use the grounding terms file at the given pathdict-> use a pre-made dictionary of normalized names to terms, with the same structure asgilda.grounder.load_terms_file()returnsAs a consequence, the redundant callings of
Grounder(get_grounding_terms())have been simplified to justGrounder().