put abs() inside the sum

inducer · Oct 20, 2021 · 1778902 · 1778902
1 parent 214e865
commit 1778902
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/grudge/reductions.py b/grudge/reductions.py
@@ -82,13 +82,10 @@ def _norm(dcoll: DiscretizationCollection, vec, p, dd) -> Any:
     if p == 2:
         from grudge.op import _apply_mass_operator
         return vec.array_context.np.sqrt(
-            # Quantities being summed are real up to rounding error, so abs() can
-            # go on the outside
-            abs(
-                nodal_sum(
-                    dcoll,
-                    dd,
-                    vec.conj() * _apply_mass_operator(dcoll, dd, dd, vec))))
+            nodal_sum(
+                dcoll,
+                dd,
+                abs(vec.conj() * _apply_mass_operator(dcoll, dd, dd, vec))))
     elif p == np.inf:
         return nodal_max(dcoll, dd, abs(vec))
     else: