Overintegration support for operators and reductions #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasgibson
force-pushed
the
thg/quad-aware-ops
branch
2 times, most recently
from
fe4926b
to
6623fab
Compare
thomasgibson
changed the title
thomasgibson
force-pushed
the
thg/quad-aware-ops
branch
2 times, most recently
from
909d387
to
91081ce
Compare
thomasgibson
force-pushed
the
thg/quad-aware-ops
branch
from
38803bc
to
1f3d139
Compare
thomasgibson
commented
Oct 14, 2021
Comment on lines
+418
to
+430
| result = dcoll._base_to_geoderiv_connection(dd_base)(result) | ||
|
|
||
| if dd.uses_quadrature(): | ||
| # NOTE: We do not want to interpolate to the quadrature grid | ||
| # unless we are using non-affine storage | ||
| # (or if *_use_geoderiv_connection* is *False*) | ||
| if not dcoll._has_affine_groups() or not _use_geoderiv_connection: | ||
| result = dcoll.connection_from_dds(dd_base, dd)(result) |
There was a problem hiding this comment.
I'm not sure I buy this logic. This suppresses the interpolation to the quadrature grid if there aren't any affine groups and _use_geoderiv_connection is true. Why? If this function gets asked to interpolate, it should.
thomasgibson
force-pushed
the
thg/quad-aware-ops
branch
2 times, most recently
from
430c87a
to
33f9702
Compare
Co-authored-by: Andreas Klöckner <inform@tiker.net>
thomasgibson
force-pushed
the
thg/array-containers
branch
from
8893ea6
to
c1e5148
Compare
Co-authored-by: Alex Fikl <alexfikl@gmail.com>
thomasgibson
force-pushed
the
thg/quad-aware-ops
branch
from
9ee1e2d
to
eb537f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the mass inverse operator to work with overintegration, updates documentation, and extends the norm/integral routines to use quadrature discretizations.
Let's please merge #154 first: