add Context manager and default context under threading #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inducer
reviewed
Oct 18, 2020
Fix future warning date of DEFAULT_CONTEXT Co-authored-by: Andreas Klöckner <inform@tiker.net>
|
I have put |
inducer
reviewed
Oct 19, 2020
| .. note:: this class implements Python's ``__copy__`` and ``__deepcopy__`` | ||
| protocals. Copying of objects of this class always returns the identity. | ||
|
|
||
| .. seealso:: :ref:`sec-context-management` |
There was a problem hiding this comment.
Please add a note on pickle behavior.
There was a problem hiding this comment.
Done.
However, I'm thinking towards a slightly better semantics of pickling of Context. I can't imagine a use case for this, but here's a sketch:
@functools.lru_cache(maxsize=None)
def _get_context_by_id(ctx_id):
return Context()
def context_reduce(self):
if self == get_default_context():
return (get_default_context, ())
return (_get_context_by_id, (hash(self), ))What do you think?
islpy/__init__.py
Outdated
| return get_default_context() | ||
|
|
||
|
|
||
| import contextlib |
Co-authored-by: Andreas Klöckner <inform@tiker.net>
Co-authored-by: Andreas Klöckner <inform@tiker.net>
Co-authored-by: Andreas Klöckner <inform@tiker.net>
Co-authored-by: Andreas Klöckner <inform@tiker.net>
…am/islpy into default_context_managing
Please have proper commit messages. |
|
(OK to leave these, just for the future.) |
|
Sorry, I believe they were generated automatically by GitHub. I will definitely note this in the future. |
They are, but you have the option to change them when you click "Commit". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #22
Semantics of context pushing is added as a test case.
With this change:
DEFAULT_CONTEXTis deprecated (with a warning) in favor ofget_default_context()get_default_context()always returns a thread unique default context for the first call in a thread.push_context(ctx=none)can be used to push new default context(s), which allows for custom default Context.__copy__and__deepcopy__which always returns the identity.