Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type stub #71

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Type stub #71

wants to merge 19 commits into from

Conversation

thisiscam
Copy link
Contributor

@thisiscam thisiscam commented Oct 19, 2021

An initial attempt that addresses #68.

The current PR provides the following working functionalities:

  • automatically generates a type stub
  • installs the type stub through setup.py

Missing:

  • the types for callbacks are not accurate enough -- I think that's worth another PR.
  • typing for helpers in islpy/__init__.py -- this will be in a separate PR.
  • make this more useful for documentation (per @inducer's comment in Type stubs for Python typing #68) -- IMO, this type stub could be useful for the time being, and it also seems to be quite standard among libraries with native extensions (e.g. pytorch)

This PR also depends on #69 . We should probably resolve that one first.

@inducer
Copy link
Owner

inducer commented Oct 20, 2021

This seems to fail most of the CI... request review when you think it's ready.

@thisiscam
Copy link
Contributor Author

Fixed the style issues. Please give it a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants