Handle use-before-assign warnings from pylint

inducer · May 20, 2024 · b2f63c2 · b2f63c2
1 parent 635546a
commit b2f63c2
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/loopy/codegen/instruction.py b/loopy/codegen/instruction.py
@@ -142,6 +142,8 @@ def generate_assignment_instruction_code(codegen_state, insn):
 
         del lhs_is_vector
         del rhs_is_vector
+    else:
+        is_vector = False
 
     # }}}
 

diff --git a/loopy/schedule/__init__.py b/loopy/schedule/__init__.py
@@ -2252,7 +2252,7 @@ def get_one_linearized_kernel(
                         callables_table)
 
     if CACHING_ENABLED and not from_cache:
-        schedule_cache.store_if_not_present(sched_cache_key, result)
+        schedule_cache.store_if_not_present(sched_cache_key, result)  # pylint: disable=possibly-used-before-assignment  # noqa: E501
 
     return result
 

diff --git a/loopy/transform/buffer.py b/loopy/transform/buffer.py
@@ -241,7 +241,9 @@ def buffer_array_for_single_kernel(kernel, callables_table, var_name,
                 index = assignee.index_tuple
 
             elif isinstance(assignee, LinearSubscript):
-                if assignee.aggregate.name == var_name:
+                assignee_name = assignee.aggregate.name
+                index = ()
+                if assignee_name == var_name:
                     raise LoopyError("buffer_array may not be applied in the "
                             "presence of linear write indexing into '%s'" % var_name)
 

diff --git a/loopy/transform/save.py b/loopy/transform/save.py
@@ -393,6 +393,7 @@ def _sortedtags(tags):
 
             my_group_tags = []
             my_local_tags = []
+            group_tags_originating_insn_id = None
 
             for iname in insn.within_inames:
                 tags = self.kernel.iname_tags(iname)
@@ -543,6 +544,8 @@ def add_subscript_if_subscript_nonempty(agg, subscript=()):
         elif mode == "reload":
             depends_on = frozenset()
             update_deps = accessing_insns_in_subkernel
+        else:
+            raise AssertionError()
 
         pre_barrier, post_barrier = self.get_enclosing_global_barrier_pair(subkernel)