Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

combine_domains: Handle inames that occur as parameters other domains #775

Merged
merged 3 commits into from
May 10, 2023
Merged

combine_domains: Handle inames that occur as parameters other domains #775

merged 3 commits into from
May 10, 2023

Conversation

inducer
Copy link
Owner

@inducer inducer commented May 10, 2023 •
edited
Loading

Draft because:

  • Needs tests

cc @isuruf

@inducer inducer changed the title Combine domains param combine_domains: Handle inames that occur as parameters other domains May 10, 2023
@inducer inducer mentioned this pull request May 10, 2023
Closed
@isuruf
Copy link
Collaborator

isuruf commented May 10, 2023

Thanks @inducer. Shall I add the example from #770 as a test?

@isuruf
Copy link
Collaborator

isuruf commented May 10, 2023

Added a reduced test

@inducer inducer marked this pull request as ready for review May 10, 2023 23:12
@inducer inducer merged commit 37c34bf into main May 10, 2023
@inducer inducer deleted the combine-domains-param branch May 10, 2023 23:12
@inducer
Copy link
Owner Author

inducer commented May 10, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@inducer @isuruf