Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExpressionToPythonMapper: use str instead of repr for map_constant #844

Closed
wants to merge 1 commit into from

Conversation

matthiasdiener
Copy link
Collaborator

@matthiasdiener matthiasdiener commented Jun 24, 2024

$ python -c 'import numpy as np; print(np.__version__, repr(np.int32(42)))'  # numpy 2
2.0.0 np.int32(42)

$ python -c 'import numpy as np; print(np.__version__, repr(np.int32(42)))'  # numpy<2
1.26.4 42

馃槺

This fixes the meshmode test failures seen in e.g. inducer/pyopencl#771

@matthiasdiener
Copy link
Collaborator Author

I wonder if more errors like this are there. I could not find any other test failures at least.

@alexfikl
Copy link
Contributor

FYI, this seems to be the same error as inducer/pymbolic#141. I fixed the test instead of fixing the mapper there, but we should have the same fix in both places!

@inducer
Copy link
Owner

inducer commented Jun 25, 2024

Thanks! #845 is an alternative, closing here.

@inducer inducer closed this Jun 25, 2024
@inducer inducer deleted the fix-repr-etpm branch June 25, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants