Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for the nifty ptpython shell. #133

Merged
merged 1 commit into from Feb 13, 2015

Conversation

pvaret
Copy link
Contributor

@pvaret pvaret commented Feb 13, 2015

This patch adds support for the awesome ptpython shell.

@asmeurer
Copy link
Collaborator

That is a neat shell. I'll give it a try for a while.

Worth noting that this suffers from the same issue as ipython (#103). If you want to try to fix it, let me know. Otherwise, it looks like this works and it can be merged.

@asmeurer
Copy link
Collaborator

There's also ptipython (I guess the main advantage is that you get %magics).

inducer added a commit that referenced this pull request Feb 13, 2015
Added support for the nifty ptpython shell.
@inducer inducer merged commit c7731ab into inducer:master Feb 13, 2015
@inducer
Copy link
Owner

inducer commented Feb 13, 2015

Thanks for your contribution!

@inducer
Copy link
Owner

inducer commented Feb 13, 2015

Btw, just released this as part of 2015.2.

@pvaret pvaret deleted the ptpython-support branch February 13, 2015 20:59
@pvaret
Copy link
Contributor Author

pvaret commented Feb 15, 2015

Re. ptipython: that's a GOOD point. My feeling was that the shell configuration interface is already starting to look a little crowded, and I was not sure the added value of that last option (IPython already being pretty fine on its own) was worth the clutter. It would probably not be too hard to add it as well, however.

As to the variable scoping issue, I'll look into it as time allows. Thanks for pointing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants