Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: macOS PUDB_TTY "I/O operation on closed file." #638

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: macOS PUDB_TTY "I/O operation on closed file." #638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion pudb/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ def _get_debugger(**kwargs):
kwargs.setdefault("stdin", tty_file)
kwargs.setdefault("stdout", tty_file)
kwargs.setdefault("term_size", term_size)
tty_file.close()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the current state is incorrect.

Please either add a comment that we're purposefully leaking the FD, or make a way for Debugger to close the FD when done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this isn't what you mean but: The file closes when the process ends. We're doing one-time initialization of resources which will be used in the indefinite future, so it seems valid to let reference counting take care of it, to me.

I'll look and see whether I can find a better solution though.


from pudb.debugger import Debugger
dbg = Debugger(**kwargs)
Expand Down