Fix build on Ubuntu/GCC 4.8.4 and 4.9.0

[larsmans]

The error was that clobj<CLType> was passed where CLType was expected. I'm not sure why this was ever supposed to work; I tried putting a type-cast operator on clobj, but that didn't work.

Fixes #81.

[yuyichao]

this is used instead of data() in order to trace which object is holding the data. If you have DEBUG_ON (either at compile time or at runtime) you should see that each call to the OpenCL API are printed with the corresponding PyOpenCL c++ wrapper address as well as the OpenCL object address. Using data() will make it only print the OpenCL pointer and at some point the ability to track c++ object pointer was important for debugging.

The general procedure is

1. On creation of an CLArgPack (which holds all the arguments), arguments is converted to CLArg.
2. The CLArg is templated on the type and in particular a specialization is defined in clobj.h to handle using clobj as argument.
3. When calling the function, CLArg::convert is called to retrive the real argument to the function and for ClArg<clobj> this should return the corresponding OpenCL object pointer.
4. As mentioned above, the convert is done at call time so that the type information is preserved for debug printing.

Can you check the output of the compiler to figure out what exactly it is complaining? (it should tell you why it cannot match each template)

[larsmans]

Here's the compiler output for the first file:

https://gist.github.com/larsmans/64e4ebc5e2ed36d548e7

There's megabytes more of this, but it's all the same kind of error.

[Starkstroem]

I still got the same error as above with 14.04 and gcc 4.9.
Anyone able to install pyopencl successfully?

[inducer]

@Starkstroem It builds without a problem for me on gcc 5.2. If you keep having issues, try 2015.1. It has the same interface on the Python side as the newer code, and has been around longer. Nonetheless, gcc 4.9 is not so old that we shouldn't at least try to get it to work.

[inducer]

@yuyichao Any clues what's happening here?

[yuyichao]

I couldn't reproduce this on GCC 4.8 or 4.9 so I'm not really sure what's happening.

As I said, this automatic casting was only useful for debugging (to track pointers) and it is certainly ok to avoid it if it's giving people to much issues.

[inducer]

e12f38a is a version of this that retains debug info if it's being built on gcc >= 5.2 and otherwise is as compatible as possible. It builds OK for me on Ubuntu 14.04. Please let me know if this resolves the issue.

[inducer]

Also, thanks @larsmans for the initial patch, and sorry for the long delay in looking at this.

[UniqueFool]

thanks for fixing this - however, would someone please so kind to update the pip tarball, so that this fix actually propagates (currently, "pip install pyopencl" will fail on all ubuntu/gcc systems mentioned above)

Referring to: https://pypi.python.org/pypi/pyopencl

Thanks

[inducer]

I've just uploaded 2015.2.2 with these fixes built in.

[UniqueFool]

thanks for being so responsive - unfortunately, it seems, there are still some issues:

Distributor ID: Ubuntu
Description: Ubuntu 14.04.3 LTS
Release: 14.04
Codename: trusty
gcc (Ubuntu 4.8.4-2ubuntu1~14.04) 4.8.4

For the pip log file, see: http://pastebin.com/mMzKrKS1

[inducer]

Ugh, sorry. That one slipped through. Should be fixed in 4be4cf5. Can you try current git?

[UniqueFool]

I can confirm that building from git, everything is building correctly - thanks again for being so responsive, WTG !
Once you have updated the pip package, I will try again and report back here.

thanks

[inducer]

2015.2.3 is on the package index.

[UniqueFool]

success, terrific maintenance job 👍