-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vtk: add typing to entire module #38
Conversation
a925b13
to
d041aed
Compare
Hm, this removed a space somewhere and it fails some meshmode test. I'll look at it tomorrow :( EDIT: Found it! Should be ok now 🚀 |
f9bb411
to
a4a292a
Compare
b995007
to
4d5c816
Compare
The commit message 'test: check reference output " suggest that output is being checked against a reference (which seems to have been added). I agree that that's a good idea, but I can't find the code that's doing the checking...? |
@inducer Oops, managed to remove that while rebasing. Should be in https://github.com/inducer/pyvisfile/compare/4d5c8163908a65f6654e8c0d8eed7bf05ea7a5d1..6592dbfa8b3221194e23848d5f3dc800895a86c6 |
Thanks! |
In my quest to add support for that
HyperTreeGrid
thing, I started slowing adding typing to thevtk
module as well. It should be fairly complete now, but it has some actual changes in there to makemypy
happy:copy
fromXMLElementBase
toXMLElement
(doesn't seem to be used anyway).EncodedBuffer
anABC
(it looked like it wanted to be aProtocol
, but this seemed easier)Visitable
forDataArray
,UnstructuredGrid
andStructuredGrid
to type "things that can generate XML".The commits should be pretty independent, so could look at them separately. There may be some fishy things in there, but
mypy --strict
is happy at least!