InlineQuestion calls markup_to_html without a PageContext

[inducer]

@dzhuang

I just discovered that you don't pass a PageContext to markup_to_html in InlineQuestion, here for example:

relate/course/page/inline.py

Line 382 in 882803a

s = markup_to_html(

As of 882803a, this breaks caching of rendered markup. (it has to, since markup rendering depends on the course for which it is done). Could you please fix this?

[dzhuang]

Yes, you're right. That will cause problems, for example, course specific links and jinja macros won't be rendered correctly.

The reason I did that is, I need to use markup_to_html to validate / get question body and answer items (of each types) in __init__ of InlineQuestion. However, there's no PageContext in __init__ method.

I will try to fix it.

[dzhuang]

I think I know how to fix it. Validation and page rendering should be separated: use vctx in validation, and use page_context when rendering html. Need sometime to modify and test.

[dzhuang]

Should be fixed in #82. However, I found images and latex expressions are not rendered correctly in ChoicesAnswer choices.