Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CPU-based rules for dependency choice #75

Closed
light-weaver opened this issue Dec 4, 2023 · 2 comments
Closed

Add CPU-based rules for dependency choice #75

light-weaver opened this issue Dec 4, 2023 · 2 comments
Assignees
@light-weaver
Labels
dependencies Pull requests that update a dependency file restructuring Label for the DESDEO restructuring project

Comments

@light-weaver
Copy link
Member

https://github.com/industrial-optimization-group/DESDEO/blob/9d03e5d736588a21603b683d4a545ca33fd9e2ad/pyproject.toml#L13C28-L13C28

The polars python package should probably be the default version that we use. There is probably a way to specify alternative dependencies based on CPU type. I will look into this if this is unresolved by the time I come back.
@light-weaver light-weaver added dependencies Pull requests that update a dependency file restructuring Label for the DESDEO restructuring project labels Dec 4, 2023
@light-weaver light-weaver self-assigned this Dec 4, 2023
light-weaver added a commit that referenced this issue Dec 14, 2023
@light-weaver
Add CPU-based rules for dependency choice
b31224c 
Fixes #75
@light-weaver light-weaver mentioned this issue Dec 14, 2023
Merged
@light-weaver
Copy link
Member Author

Added some ruff rules in as well

@gialmisi
Copy link
Contributor

gialmisi commented Jan 8, 2024

The current solutions seems to work for me at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@light-weaver light-weaver

Labels
dependencies Pull requests that update a dependency file restructuring Label for the DESDEO restructuring project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@light-weaver @gialmisi