Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid signature leads to process termination #42

Open
thirtified opened this issue Nov 9, 2020 · 1 comment
Open

Invalid signature leads to process termination #42

thirtified opened this issue Nov 9, 2020 · 1 comment

Comments

@thirtified
Copy link

The findResponder() routing in verify.js will throw an exception in case it is unable to verify the signature. This exception is not caught in verify() and thus will lead to crashing of the application.

project/node_modules/ocsp/lib/ocsp/verify.js:25
      throw new Error('Invalid signature');
      ^

Error: Invalid signature
    at findResponder (project/node_modules/ocsp/lib/ocsp/verify.js:25:13)
    at Object.verify (project/eidas-cert-check/node_modules/ocsp/lib/ocsp/verify.js:72:22)
    at project/node_modules/ocsp/lib/ocsp/check.js:38:12
    at done (project/node_modules/ocsp/lib/ocsp/utils.js:26:7)
    at IncomingMessage.<anonymous> (project/node_modules/ocsp/lib/ocsp/utils.js:46:7)
    at IncomingMessage.emit (events.js:327:22)
    at endReadableNT (_stream_readable.js:1224:12)
    at processTicksAndRejections (internal/process/task_queues.js:84:21)
thirtified pushed a commit to thirtified/ocsp that referenced this issue Nov 9, 2020
Fixing uncaught exception when signature verification fails – fixes indutny#42.
@thirtified
Copy link
Author

Great, turns out there is already a pending PR for this: #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant