Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run into an error that's crashed our monitoring service. In short, when trying to check an https service which runs an expired certificate, nodejs doesn't create
socket.ssl
(at least in node v13), and thusoscp
proceeds to throw an error. In our case, we're using thehttps
module withocsp
'sAgent
, which produces the following error:This can be fixed by moving the relevant code into the
try/catch
statement that already exists inAgent.prototype.handleOCSPResponse
, which then allowshttps
to display the actual error properly: