Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derived time interval #12

Merged
merged 4 commits into from
Oct 28, 2011
Merged

Derived time interval #12

merged 4 commits into from
Oct 28, 2011

Conversation

TimidRobot
Copy link
Contributor

  • derived time interval code changes
  • derived time interval documentation changes
  • add myself to contributions

@indygreg
Copy link
Owner

Alright, this looks to be exactly what is needed! A couple of small nitpicks that I'd like addressed before merging:

  1. data['intervals'] and data['derive'] seem ambiguous to me. When there was only 1, it was tolerable (even then, I never liked the term 'derive'). Now there are 2 flags controlling behavior and the wording may not be clear to a casual reader. How about renaming 'derive' to 'differentiate_values' and 'intervals' to 'differentiate_time'? I'm also tossing around the idea of making 'differentiate_time' imply 'differentiate_values.' If that's done, perhaps 'differentiate_values_over_time' would be better. Does that make sense? I'm open to feedback here.

  2. Can you store the previous time and value as a tuple inside data['values'][metric]? The data is logically a pair, so it should be stored as such. And, it might be a little faster, since it only performs 1 dictionary lookup for 'metric,' not 2.

Almost there...

@indygreg indygreg mentioned this pull request Oct 26, 2011
Closed
Tim Baldoni added 2 commits October 26, 2011 21:34
Merge remote-tracking branch 'upstream/master' into derived_time_inte…
5515b92 
…rval

Conflicts:
	carbon_writer.py
Change to DifferentiateCounters and DifferentiateCountersOverTime
47edb1f 
- Rename DeriveCounters to DifferentiateCounters
- Rename DeriveIntervals to DifferentiateCountersOverTime
- Make DifferentiateCountersOverTime imply DifferentiateCountersOverTime
- Store both time and values within data['values'][metric]
@indygreg indygreg merged commit 47edb1f into indygreg:master Oct 28, 2011
@indygreg
Copy link
Owner

Tim,

I just merged and pushed your commits!

I did make one slight change to your code, which you can see in commit 724ffb6. It didn't change the spirit of your commits in any way.

Thank you once again for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TimidRobot @indygreg