Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZstdDecompressionReader.closed should be a property, not method. #58

Closed
gwk opened this issue Oct 8, 2018 · 1 comment
Closed

ZstdDecompressionReader.closed should be a property, not method. #58

gwk opened this issue Oct 8, 2018 · 1 comment

Comments

@gwk
Copy link

gwk commented Oct 8, 2018 •
edited

IOBase defines closed as a property, and the builtin decompressors types for gz and lzma/xz follow this API. It would be great if Zstandard could match that; as it is, when you try to create a TextIOWrapper with a ZstdDecompressionReader, the read fails with "ValueError: I/O operation on closed file.", because the closed method evaluates to True.
indygreg added a commit that referenced this issue Oct 8, 2018
@indygreg
compressionreader: make closed a property instead of a method (#58)
f2f4f7c 
This conforms with the IOBase API.
@indygreg
Copy link
Owner

indygreg commented Oct 8, 2018

This will be fixed in 0.10.1.

@indygreg indygreg closed this as completed Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@indygreg @gwk