Fix memory leak in stream_reader seek, fixes #82 #83
Conversation
|
@indygreg Can you explain what fails at the tests? It seems it trys to curl download something but what curl returns is not a zip file. Maybe add |
|
After adding the curl option it's clear the download fails with a 404. @indygreg what is happening here? |
|
This bug is really bothering us, it would be great if this simple fix could be merged and a new release be made. |
|
The memory leak patch was committed to master and the 0.11 branch and 0.11.1 was tagged and released. I'll attend to the curl patch another day, as it isn't as important (and arguably not necessary). The commit message doesn't say why it is warranted. Is that commit even needed? |
|
The Error Message on Travis was very unclear. This improved it. These flags are generally considered best practice for curl. |
No description provided.