Add environment variables for SSR enabled and url options #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
inertia.ssr.enabledandinertia.ssr.urlwith environment variables:INERTIA_SSR_ENABLED, with default value oftrueINERTIA_SSR_URL, with default value ofhttp://127.0.0.1:13714Why?
As it would be nice to be able to configure these values out of the box based on environment variables (for example when running in Docker or Kubernetes), this makes it so people don't have to publish the configuration to edit these values. Nor does it require file system changes, cause ideally all external dependencies of an app should be able to be configured through environment.