Fix form helper transform return type in React adapter
#1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rejin-r
commented
Jun 14, 2024
| @@ -18,7 +18,7 @@ export interface InertiaFormProps<TForm extends FormDataType> { | |||
| wasSuccessful: boolean | |||
| recentlySuccessful: boolean | |||
| setData: setDataByObject<TForm> & setDataByMethod<TForm> & setDataByKeyValuePair<TForm> | |||
| transform: (callback: (data: TForm) => TForm) => void | |||
| transform: (callback: (data: TForm) => object) => void | |||
There was a problem hiding this comment.
The return value cannot be of type TForm as that defeats the purpose of transform. It should be anything but TForm. 😄
thecrypticace
approved these changes
Jun 17, 2024
reinink
changed the title
transform return type in React adapter
|
Thanks! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix for a wrong type for the transform function in the react package.