Remove "onBeforeRender" event and add "errors" option to preserveScroll and preserveState #628
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts a previous change (#410) that added a new
onBeforeRender()
event, used by the Vue 2 and Vue 3 form helpers to set form state earlier in the visit lifecycle. As it turns out, this creates other issues, such as the page props being out of date whenform.processing
returns back tofalse
.The entire motivation with adding
onBeforeRender()
was to simplify this:To this:
Instead of solving the problem that way, I've introduced a new option to
preserveScroll
andpreserveState
specifically for preserving the scroll/state when there are errors:Overall I think this is a much better solution. 👍