Skip to content

Commit

Permalink
python: Changed chart tests to print running the simulations and alwa…
Browse files Browse the repository at this point in the history
…ys do the chart exporting.

Silently running a lot of simulations is confusing for the user.
Silently not running the chart tests if one of the simulations fail is also very confusing.
  • Loading branch information
levy committed Mar 24, 2023
1 parent 2499758 commit 59bbb86
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions python/inet/test/chart.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,8 @@ def __init__(self, multiple_simulation_tasks=None, name="chart test", multiple_t
self.multiple_simulation_tasks = multiple_simulation_tasks

def run_protected(self, **kwargs):
multiple_simulation_task_results = self.multiple_simulation_tasks.run_protected(output_stream=io.StringIO(), **kwargs)
if multiple_simulation_task_results.result != "DONE":
return self.multiple_task_results_class(self, result=multiple_simulation_task_results.result)
else:
return super().run_protected(**kwargs)
multiple_simulation_task_results = self.multiple_simulation_tasks.run_protected(**kwargs)
return super().run_protected(**kwargs)

def get_chart_test_tasks(simulation_project=default_project, run_simulations=True, filter=None, working_directory_filter=None, pool_class=multiprocessing.Pool, **kwargs):
test_tasks = []
Expand Down

0 comments on commit 59bbb86

Please sign in to comment.