Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome E-Mail template #304

Closed
MHammett opened this issue Mar 25, 2017 · 7 comments
Closed

Welcome E-Mail template #304

MHammett opened this issue Mar 25, 2017 · 7 comments

Comments

@MHammett
Copy link

MHammett commented Mar 25, 2017

I have no template e-mail file and I get the generic welcome e-mail.

I cp /srv/ixpmanager/application/views/_skins/inex/customer/email/welcome-email.phtml /srv/ixpmanager/application/views/_skins/M-IX/customer/email/welcome-email.phtml

and now my send e-mail screen results in:

`Development Platform Detected! Display errors enabled via application.ini. Disable in production!

ErrorException
File
/srv/ixpmanager/var/templates_c/a0967060a1a03aa90fed502829c1932b1de90a4a_0.file.welcome-email.phtml.php
Line
110
Message
Undefined offset: 1
Code
0
Trace
#0 /srv/ixpmanager/var/templates_c/a0967060a1a03aa90fed502829c1932b1de90a4a_0.file.welcome-email.phtml.php(110): Illuminate\Foundation\Bootstrap\HandleExceptions->handleError(8, 'Undefined offse...', '/srv/ixpmanager...', 110, Array)
#1 /srv/ixpmanager/vendor/smarty/smarty/libs/sysplugins/smarty_template_resource_base.php(128): content_58d6eb320c2667_63127290(Object(Smarty_Internal_Template))
#2 /srv/ixpmanager/vendor/smarty/smarty/libs/sysplugins/smarty_template_compiled.php(172): Smarty_Template_Resource_Base->getRenderedTemplateCode(Object(Smarty_Internal_Template))
#3 /srv/ixpmanager/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php(206): Smarty_Template_Compiled->render(Object(Smarty_Internal_Template))
#4 /srv/ixpmanager/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatebase.php(216): Smarty_Internal_Template->render(false, 0)
#5 /srv/ixpmanager/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatebase.php(107): Smarty_Internal_TemplateBase->_execute(Object(Smarty_Internal_Template), NULL, NULL, NULL, 0)
#6 /srv/ixpmanager/library/OSS/View/Smarty.php(300): Smarty_Internal_TemplateBase->fetch('_skins/M-IX/cus...')
#7 /srv/ixpmanager/application/controllers/CustomerController.php(623): OSS_View_Smarty->render('customer/email/...')
#8 /srv/ixpmanager/vendor/zendframework/zendframework1/library/Zend/Controller/Action.php(516): CustomerController->welcomeEmailAction()
#9 /srv/ixpmanager/vendor/zendframework/zendframework1/library/Zend/Controller/Dispatcher/Standard.php(308): Zend_Controller_Action->dispatch('welcomeEmailAct...')
#10 /srv/ixpmanager/vendor/zendframework/zendframework1/library/Zend/Controller/Front.php(954): Zend_Controller_Dispatcher_Standard->dispatch(Object(Zend_Controller_Request_Http), Object(Zend_Controller_Response_Http))
#11 /srv/ixpmanager/vendor/zendframework/zendframework1/library/Zend/Application/Bootstrap/Bootstrap.php(105): Zend_Controller_Front->dispatch()
#12 /srv/ixpmanager/vendor/zendframework/zendframework1/library/Zend/Application.php(384): Zend_Application_Bootstrap_Bootstrap->run()
#13 /srv/ixpmanager/app/Exceptions/Handler.php(59): Zend_Application->run()
#14 /srv/ixpmanager/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(82): IXP\Exceptions\Handler->render(Object(Illuminate\Http\Request), Object(Symfony\Component\HttpKernel\Exception\NotFoundHttpException))
#15 /srv/ixpmanager/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(32): Illuminate\Routing\Pipeline->handleException(Object(Illuminate\Http\Request), Object(Symfony\Component\HttpKernel\Exception\NotFoundHttpException))
#16 /srv/ixpmanager/vendor/barryvdh/laravel-debugbar/src/Middleware/Debugbar.php(51): Illuminate\Routing\Pipeline->Illuminate\Routing{closure}(Object(Illuminate\Http\Request))
#17 /srv/ixpmanager/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148): Barryvdh\Debugbar\Middleware\Debugbar->handle(Object(Illuminate\Http\Request), Object(Closure))
#18 /srv/ixpmanager/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request))
#19 /srv/ixpmanager/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(30): Illuminate\Routing\Pipeline->Illuminate\Routing{closure}(Object(Illuminate\Http\Request))
#20 /srv/ixpmanager/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148): Illuminate\Foundation\Http\Middleware\TransformsRequest->handle(Object(Illuminate\Http\Request), Object(Closure))
#21 /srv/ixpmanager/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request))
#22 /srv/ixpmanager/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(30): Illuminate\Routing\Pipeline->Illuminate\Routing{closure}(Object(Illuminate\Http\Request))
#23 /srv/ixpmanager/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148): Illuminate\Foundation\Http\Middleware\TransformsRequest->handle(Object(Illuminate\Http\Request), Object(Closure))
#24 /srv/ixpmanager/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request))
#25 /srv/ixpmanager/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ValidatePostSize.php(27): Illuminate\Routing\Pipeline->Illuminate\Routing{closure}(Object(Illuminate\Http\Request))
#26 /srv/ixpmanager/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148): Illuminate\Foundation\Http\Middleware\ValidatePostSize->handle(Object(Illuminate\Http\Request), Object(Closure))
#27 /srv/ixpmanager/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request))
#28 /srv/ixpmanager/app/Http/Middleware/UrlResolver.php(58): Illuminate\Routing\Pipeline->Illuminate\Routing{closure}(Object(Illuminate\Http\Request))
#29 /srv/ixpmanager/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148): IXP\Http\Middleware\UrlResolver->handle(Object(Illuminate\Http\Request), Object(Closure))
#30 /srv/ixpmanager/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request))
#31 /srv/ixpmanager/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/CheckForMaintenanceMode.php(46): Illuminate\Routing\Pipeline->Illuminate\Routing{closure}(Object(Illuminate\Http\Request))
#32 /srv/ixpmanager/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(148): Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode->handle(Object(Illuminate\Http\Request), Object(Closure))
#33 /srv/ixpmanager/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request))
#34 /srv/ixpmanager/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(102): Illuminate\Routing\Pipeline->Illuminate\Routing{closure}(Object(Illuminate\Http\Request))
#35 /srv/ixpmanager/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(149): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#36 /srv/ixpmanager/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(116): Illuminate\Foundation\Http\Kernel->sendRequestThroughRouter(Object(Illuminate\Http\Request))
#37 /srv/ixpmanager/public/index.php(84): Illuminate\Foundation\Http\Kernel->handle(Object(Illuminate\Http\Request))
#38 {main}`

@barryo
Copy link
Member

barryo commented Apr 3, 2017

Hi @MHammett - the key piece of information seems to have been cut:

#0 /srv/ixpmanager/var/templates_c/a0967060a1a03aa90fed502829c1932b1de90a4a_0.file.welcome-email.phtml.php(110): Illuminate\Foundation\Bootstrap\HandleExceptions->handleError(8, 'Undefined offse...', '/srv/ixpmanager...', 110, Array)

Does this still occur post using the now documented update instructions:

https://ixp-manager.readthedocs.io/en/latest/install/upgrading/:

I'm going to guess not and close this on the assumption it was a database schema issue.

If I'm wrong, please reopen and:

  1. confirm if it happens before you try and skin the template
  2. try and find the missing detail for the error above

@barryo barryo closed this as completed Apr 3, 2017
@MHammett
Copy link
Author

MHammett commented Apr 3, 2017

I upgraded per documentation (and saw various things updated).

welcome-mail.log.txt

mv /srv/ixpmanager/application/views/_skins/M-IX/customer/email/welcome-email.phtml /srv/ixpmanager/application/views/_skins/M-IX/customer/email/welcome-email.phtml.old

and then it works.

cp /srv/ixpmanager/application/views/_skins/inex/customer/email/welcome-email.phtml /srv/ixpmanager/application/views/_skins/M-IX/customer/email/welcome-email.phtml

and it does not.

@barryo
Copy link
Member

barryo commented Apr 3, 2017

cp /srv/ixpmanager/application/views/_skins/inex/customer/email/welcome-email.phtml /srv/ixpmanager/application/views/_skins/M-IX/customer/email/welcome-email.phtml

Right, I didn't realise you were using the INEX template. We have some custom variables in there.

I suspect you're tripping up on a lack of netinfo - see:

https://github.com/inex/IXP-Manager/wiki/Installation-08-Setting-Up-Your-IXP#network-info

We don't really use netinfo anywhere else these days. You can certainly work from INEX's templates but sometimes they'll have legacy stuff in them 😢

The recommended approach to skinning is to copy the default templates for this reason. INEX's are included to provide examples and hint at additional things you can do (but often requires PHP skillz).

@MHammett
Copy link
Author

MHammett commented Apr 3, 2017

I had originally copied ours from our old server to the new server. When that failed, I tried the INEX one, assuming it would work everywhere. The default letter in v4 is rather bland, which is why I pulled the old one across.

netinfo would certainly be missing and I'm fairly certain I used them on our other server.

Is there any way to get a more useful error or log? Hundreds of lines and none of them mention netinfo.

This is all the stock welcome mail says

Dear New Member,

Firstly, welcome to St. Louis Regional Internet Exchange! This is your St. Louis Regional Internet Exchange welcome e-mail.

Please take some time to read this email -- it contains important information concerning your St. Louis Regional Internet Exchange membership.

Several sections of this email require your input; these are all clearly marked by the heading "Your Input". We would appreciate if you could provide us with all the details requested as this will allow us to provide you and other St. Louis Regional Internet Exchange members with a better quality of service.

---- COMPLETE YOURSELF VIA SKIN ----

Welcome to St. Louis Regional Internet Exchange.

@barryo
Copy link
Member

barryo commented Apr 3, 2017

The default letter in v4 is rather bland

Yip, we're not copy writers I'm afraid :-P YMMV but we'd expect that IXPs would want to personalise their own welcome emails. Also ours is information overload and we're moving away from it tbh.

Is there any way to get a more useful error or log?

Line 1 of the log indicates the issue:

#0 /srv/ixpmanager/var/templates_c/a0967060a1a03aa90fed502829c1932b1de90a4a_0.file.welcome-email.phtml.php(110): Illuminate\Foundation\Bootstrap\HandleExceptions->handleError(8, 'Undefined offse...', '/srv/ixpmanager...', 110, Array)

The file in question is a generated template. Knowing you were using INEX's, I looked into our version of that and spotted netinfo.

@MHammett
Copy link
Author

MHammett commented Apr 3, 2017

Adding that information I did get INEX's welcome mail to work. I also discovered that I had copied the user welcome e-mail from the old server into the new customer welcome e-mail on the new server. Oops.

@MHammett
Copy link
Author

MHammett commented Apr 3, 2017

We're also not copywriters and know that you guys and LONAP and... know your stuff... so we borrow extensively from examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants