Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendergraph input validation #204

Open
2 tasks
Tracked by #533
yeetari opened this issue Jul 29, 2020 · 0 comments
Open
2 tasks
Tracked by #533

Rendergraph input validation #204

yeetari opened this issue Jul 29, 2020 · 0 comments
Labels
cat:enhancement enhancement/requested feature/update of existing features feat:frame graph frame graph prio:low This has low priority.

Comments

@yeetari
Copy link
Member

yeetari commented Jul 29, 2020 •
edited
Loading

Currently, the frame graph features almost no input validation. This means that it is very easy to get the frame graph to build vulkan objects in invalid states, and sometimes even segfault. Logging is also currently very sparse.

  • Better logging
  • Handle duplicate shaders (e.g. two vertex shaders)
@yeetari yeetari mentioned this issue Jul 29, 2020
Merged
14 tasks
@IceflowRE IceflowRE added the org:triage labels have to be specified or checked label Jul 29, 2020
@yeetari yeetari added cat:enhancement enhancement/requested feature/update of existing features feat:frame graph frame graph prio:low This has low priority. and removed org:triage labels have to be specified or checked labels Jul 30, 2020
@IAmNotHanni IAmNotHanni pinned this issue Aug 3, 2020
@IAmNotHanni IAmNotHanni unpinned this issue Jan 8, 2021
@IAmNotHanni IAmNotHanni mentioned this issue Mar 19, 2023
Closed
13 tasks
@IAmNotHanni IAmNotHanni changed the title Frame graph input validation Rendergraph input validation May 13, 2023
@IAmNotHanni IAmNotHanni mentioned this issue Jun 14, 2023
Draft
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cat:enhancement enhancement/requested feature/update of existing features feat:frame graph frame graph prio:low This has low priority.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yeetari @IceflowRE