Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rendergraph] Refactoring, part 1 of 2 #524

Closed
wants to merge 14 commits into from

Conversation

IAmNotHanni
Copy link
Member

@IAmNotHanni IAmNotHanni commented Mar 8, 2023

Changes

Closes #277

  • Implement uses_shaders
  • Implement push_constant_range template method
  • Refactor handling of vertex input attribute descriptions
  • Set texture format directly in constructor of TextureResource and remove set_format method
  • Make calls to render stage setup chainable
  • Add wrapper for VkPipelineLayout
  • Add wrapper for graphics pipelines
  • Add graphics pipeline builder
  • Add wrapper for VkRenderPass (This will go away once we have dynamic rendering)
  • Add renderpass builder (Renderpasses will be removed anyways once we support dynamic rendering: Implement support for dynamic rendering #438)
  • Add wrapper for VkSampler
  • Refactor Image RAII wrapper class and use it in rendergraph
  • Remove unused MeshBuffer class
  • Remove unused msaa_target.hpp file

Outlook: Refactoring, part 2

@IAmNotHanni IAmNotHanni added the cat:refactor refactor/clean up/simplifications/etc. label Mar 8, 2023
@IAmNotHanni IAmNotHanni self-assigned this Mar 8, 2023
@IAmNotHanni IAmNotHanni changed the title Small refactoring of rendergraph Refactoring of rendergraph Mar 8, 2023
@IAmNotHanni IAmNotHanni force-pushed the hanni/rendergraph_refactoring branch 2 times, most recently from b0a2c97 to 0efd073 Compare March 12, 2023 14:22
@IAmNotHanni IAmNotHanni changed the title Refactoring of rendergraph [rendergraph] Refactoring, part 1 of 2 Mar 16, 2023
@IAmNotHanni IAmNotHanni force-pushed the hanni/rendergraph_refactoring branch from 0efd073 to 898db30 Compare March 18, 2023 20:32
@IAmNotHanni IAmNotHanni marked this pull request as ready for review March 18, 2023 20:33
@IAmNotHanni IAmNotHanni marked this pull request as draft March 24, 2023 22:21
@IAmNotHanni
Copy link
Member Author

I am working on a new rendergraph implementation currently, so I converted it back to a draft. We might not need all of this.

@IAmNotHanni
Copy link
Member Author

I will close this because it will come back as rendergraph2 soon.
It makes no sense to refactor here if I will rewrite it from scratch again anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:refactor refactor/clean up/simplifications/etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use builder pattern for the graphics pipeline
1 participant