The response will always be an array #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I was actually torn about this when first designing the API. It does make a lot of sense to always return an array. It means breaking the current API, but I'm not against that. Can you also update the README though? The Responses section would be made outdated by this PR. |
MatayoshiMariano
force-pushed
the
refactor/return-array
branch
from
8ef0bf9
to
ff7a87c
Compare
|
Done! |
|
Hi! I'm sorry for the delay, I've been a little busy the past few days, plus I wanted to get a version out before this was merged, since the API will become backwards-incompatible. Thanks for the contribution! |
inf0rmer
added a commit
that referenced
this pull request
Jan 29, 2015
Always makes response an Array
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's better that the response will be an array of
Responseinstead of aResponseor an array ofResponse, because the response is unified, in the last case is not.