Updating CodeceptionAdapter.php 'run' command #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Could you please add a test to avoid regression? |
Well do. |
edwin-benitez
force-pushed
the
master
branch
3 times, most recently
from
40f7298
to
b17e265
Compare
Updating the run command to go before arguments and options.
|
I have added the test but Travis ci is not running. Not sure why it is not running. |
looks good to me, tests are green. Thank you @edwin-benitez! |
|
@maks-rafalko , I think you made the release but didn't actually merge in the changes... |
|
Thank you @Fenikkusu, shit happens ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When putting in
--test-framework-options, it is putting the options before theruncommand. The fix is to make sure the options are place after theruncommand.Before changes: Running
infection --test-framework-options="--skip blah"runs the commandcodecept --skip blah runAfter changes: Running
infection --test-framework-options="--skip blah"runs the commandcodecept run --skip blah