Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Codeception 4 support, php < 8.0 and symfony < 5.0 #22

Merged
merged 2 commits into from
Oct 15, 2023
Merged

Drop Codeception 4 support, php < 8.0 and symfony < 5.0 #22

merged 2 commits into from
Oct 15, 2023

Conversation

sidz
Copy link
Member

@sidz sidz commented Oct 15, 2023 •
edited
Loading

This PR:

  • Drops Codeception 4 support
  • Drops PHP < 8.0 support
  • Drops Symfony < 5.0 support (Can't use 5.4 as s lowest dependency due to php-coveralls/php-coveralls constraints)

@sidz sidz marked this pull request as ready for review October 15, 2023 18:29
@sidz sidz force-pushed the codeception-5-support branch 7 times, most recently from 3405451 to 588215f Compare October 15, 2023 19:09
maks-rafalko
maks-rafalko approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think, does it make sense to drop 8.0 as well since it's not supported for Infection and won't have security fixes in a month?

@sidz
Copy link
Member Author

sidz commented Oct 15, 2023

@maks-rafalko maybe we could do one release which supports 8.0 for those who for some reason may stay with 8.0. Does it make sense for you?

@maks-rafalko
Copy link
Member

Ok, thank you @sidz

@maks-rafalko maks-rafalko merged commit 7ac1030 into master Oct 15, 2023
12 checks passed
@maks-rafalko maks-rafalko deleted the codeception-5-support branch October 15, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maks-rafalko maks-rafalko maks-rafalko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sidz @maks-rafalko