Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 support #3

Merged
merged 2 commits into from Feb 1, 2021
Merged

PHP 8 support #3

merged 2 commits into from Feb 1, 2021

Conversation

sidz
Copy link
Member

@sidz sidz commented Jan 12, 2021

This PR:

  • adds PHP 8 support.
  • update dev dependencies

@sidz sidz force-pushed the php-8-support branch 2 times, most recently from be44dc6 to eebef99 Compare January 18, 2021 21:00
@ctrl-f5
Copy link

ctrl-f5 commented Jan 27, 2021

hello @sidz can you give this one an update? travis is failing but your previous MR moved builds to github actions, right?

@sidz
Copy link
Member Author

sidz commented Jan 27, 2021

@ctrl-f5

travis is failing but your previous MR moved builds to github actions, right?

Yes. you are right. I'll rebase this PR.

can you give this one an update?

I'll try to find some time to finish this PR. There also some issues with e2e tests.

},
"conflict": {
"codeception/codeception": "<3.1.1"
"codeception/codeception": "<4.1.9"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumped up codeception/codeception as it compatible with both 7.4 and 8.0

@sidz sidz force-pushed the php-8-support branch 2 times, most recently from f44ce83 to bb6aa3f Compare January 31, 2021 16:27
@sidz sidz merged commit 2b68c8e into master Feb 1, 2021
@sidz sidz deleted the php-8-support branch February 1, 2021 17:37
@sidz
Copy link
Member Author

sidz commented Feb 1, 2021

Thanks @maks-rafalko

@ctrl-f5 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants