Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow sending stryker-mutator.io reports for multiple branches #1536

Closed
Ocramius opened this issue Jul 14, 2021 · 1 comment · Fixed by #1538
Closed

Allow sending stryker-mutator.io reports for multiple branches #1536

Ocramius opened this issue Jul 14, 2021 · 1 comment · Fixed by #1538
Labels
DX Developer Experience Feature Request
Milestone
0.24.0

Comments

@Ocramius
Copy link
Sponsor Contributor

Since approximately 2019, I started moving away from the master branch naming, and started to use the minor version of libraries as branch name, such as:

  • 1.0.x
  • 2.1.x
  • ...

Infection has a configuration for sending information to stryker-mutator.io, but only when the branch name matches precisely:

infection/src/Logger/BadgeLogger.php

Line 86 in f2290b5

if ($buildContext->branch() !== $this->branch) {

Would a patch to change this into a regex (perhaps new setting, if necessary?) be welcome?
@maks-rafalko maks-rafalko added DX Developer Experience Feature Request labels Jul 14, 2021
@maks-rafalko
Copy link
Member

maks-rafalko commented Jul 14, 2021 •
edited

Would a patch to change this into a regex (perhaps new setting, if necessary?) be welcome?

Absolutely!

related to

Ocramius added a commit to Ocramius/infection that referenced this issue Jul 14, 2021
@Ocramius
New logs.badge.matchBranchRegex config to match multiple branches i…
57b341c 
…n reporting

By configuring `logs.badge.matchBranchRegex`, it is possible to set multiple branches to report
their mutation score to upstream tools:

```json
{
    "source": {
        "directories": ["src/"]
    },
    "logs": {
        "badge": {
            "matchBranchRegex": "/^release-.*$/"
        }
    }
}
```

Note that `logs.badge.matchBranchRegex` is mutually exclusive with `logs.badge.branch`, which
is much more restrictive: the two cannot be used together.

Fixes infection#1536
@Ocramius Ocramius mentioned this issue Jul 14, 2021
Merged
3 tasks
Ocramius added a commit to Ocramius/infection that referenced this issue Jul 20, 2021
@Ocramius
Made logs.badge.branch capable of accepting a regular expression
1d45ad8 
By configuring `logs.badge.branch` with a `/`-delimited regular expression, we can collect
reports about a number of branches.

```json
{
    "source": {
        "directories": ["src/"]
    },
    "logs": {
        "badge": {
            "branch": "/^release-.*$/"
        }
    }
}
```

Note that `logs.badge.matchBranchRegex`, initially proposed as an alternative, has also been removed.

We can safely assume that a `branch` value starting and ending with `/` is a regular expression, because
git branches starting or ending with `/` are not valid anyway.

Fixes infection#1536
Ocramius added a commit to Ocramius/infection that referenced this issue Jul 21, 2021
@Ocramius
New logs.badge.matchBranchRegex config to match multiple branches i…
a0d0b99 
…n reporting

By configuring `logs.badge.matchBranchRegex`, it is possible to set multiple branches to report
their mutation score to upstream tools:

```json
{
    "source": {
        "directories": ["src/"]
    },
    "logs": {
        "badge": {
            "matchBranchRegex": "/^release-.*$/"
        }
    }
}
```

Note that `logs.badge.matchBranchRegex` is mutually exclusive with `logs.badge.branch`, which
is much more restrictive: the two cannot be used together.

Fixes infection#1536
Ocramius added a commit to Ocramius/infection that referenced this issue Jul 21, 2021
@Ocramius
Made logs.badge.branch capable of accepting a regular expression
3c1e4da 
By configuring `logs.badge.branch` with a `/`-delimited regular expression, we can collect
reports about a number of branches.

```json
{
    "source": {
        "directories": ["src/"]
    },
    "logs": {
        "badge": {
            "branch": "/^release-.*$/"
        }
    }
}
```

Note that `logs.badge.matchBranchRegex`, initially proposed as an alternative, has also been removed.

We can safely assume that a `branch` value starting and ending with `/` is a regular expression, because
git branches starting or ending with `/` are not valid anyway.

Fixes infection#1536
theofidry pushed a commit that referenced this issue Jul 21, 2021
@Ocramius
Made logs.badge.branch capable of accepting a regular expression (#…
0dde91a 
…1538)

Fixes #1536
Fixes #814

Related: #1137
Related: #1149
@maks-rafalko maks-rafalko added this to the 0.24.0 milestone Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DX Developer Experience Feature Request
Projects
None yet
Milestone
0.24.0
Development

Successfully merging a pull request may close this issue.

Made logs.badge.branch capable of accepting a regular expression Ocramius/infection
2 participants
@Ocramius @maks-rafalko